Implement shadow instead of hr #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabinskij
requested review from
BhagyaPrasadSamarathunga,
Konzisam,
alinaincodeland,
dvnishshanka,
006080,
GabrielMelhem,
BajalanIman,
miklesch and
messkalina
Closed
|
I’m not completely in agreement with the shadow implementation you used in the Header. I’ve opened a new ticket #266 to address this and will work on refining it. The shadow should be applied to the CategoriesTab component and should appear on the scroll, fixing itself at a specific point. |
grabinskij
removed request for
BhagyaPrasadSamarathunga,
Konzisam,
alinaincodeland,
dvnishshanka,
006080,
GabrielMelhem,
BajalanIman,
miklesch and
messkalina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced the hr divider with a shadow effect in the header, as the hr divider overlaps with overlays in popups and dropdowns.